EDK 4.4.0.0 with ESI support

EDK releases + Open discussion and chat about EDK.
User avatar
Rounon Dax
Greenhorn
Posts: 21
Joined: Sat Jul 11, 2015 17:15

Re: EDK 4.4.0.0 with ESI support

Post by Rounon Dax » Thu May 10, 2018 18:36

Salvoxia wrote:
Thu May 10, 2018 16:11
@Rounon Dax:

Could you please replace your common/includes/class.esiparser.php with this one (right click -> save as) and check if that helps?

Best Regards,
Salvoxia
That one did the trick, thanks!

anchorhead
Someday Author
Posts: 89
Joined: Thu May 16, 2013 12:48

Re: EDK 4.4.0.0 with ESI support

Post by anchorhead » Thu May 10, 2018 20:42

anchorhead wrote:
Thu May 10, 2018 16:02
Hello Salvoxia,

I tried with link to refresh description in upgrade section but always :
Fatal error: Call to a member function getAttribute() on null in /var/www/xxxx/update/CCPDB/xml.parser.php on line 118
ok i found, it was wrong permission on /cache/update folder ... thanks for your support

But for this error i don't know :
Strict Standards: Static function statSummary::addKill() should not be abstract in /var/www/xxx/common/includes/class.statsummary.php on line 119
Strict Standards: Static function statSummary::delKill() should not be abstract in /var/www/xxx/common/includes/class.statsummary.php on line 125
Strict Standards: Static function statSummary::update() should not be abstract in /var/www/xxx/common/includes/class.statsummary.php on line 132

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK 4.4.0.0 with ESI support

Post by Salvoxia » Thu May 10, 2018 20:59

Hi,

these are strictly spoken not errors but just notices, everything should still work. They are visible because of a wrong error reporting setting, the linked Fix #2 in this post should take care of that.
I'll look into cleaning it up, nevertheless.

Best Regards,
Salvoxia

anchorhead
Someday Author
Posts: 89
Joined: Thu May 16, 2013 12:48

Re: EDK 4.4.0.0 with ESI support

Post by anchorhead » Thu May 10, 2018 21:34

Salvoxia wrote:
Thu May 10, 2018 20:59
Hi,

these are strictly spoken not errors but just notices, everything should still work. They are visible because of a wrong error reporting setting, the linked Fix #2 in this post should take care of that.
I'll look into cleaning it up, nevertheless.

Best Regards,
Salvoxia
ok fine thanks you

neffets
Greenhorn
Posts: 28
Joined: Fri May 24, 2013 12:06

Re: EDK 4.4.0.0 with ESI support

Post by neffets » Thu May 10, 2018 21:39

Code: Select all

cron/cron_esi.php
#!/usr/bin/env php 2018/05/10 19:34:18 - Starting ESI Import
2018/05/10 19:35:30 - ESI SSO Key: MyName (type: corp)
2018/05/10 19:35:30 - 0 kills were posted and 0 were skipped (1000 kills fetched)
2018/05/10 19:35:30 - Last kill ID: 498804
2018/05/10 19:35:30 - Stopped parsing after reaching maximum processing time of 55 seconds.
2018/05/10 19:35:30 - Spent 66.104444980621s talking to ESI
2018/05/10 19:35:30 - Time taken = 72.601155996323 seconds.


Suggestion: Add the date/time of the last kill plz ;) I wanna know how long this litte guy has to run to be on top ;)

celagon
Apprentice
Posts: 40
Joined: Mon Oct 07, 2013 01:50

Re: EDK 4.4.0.0 with ESI support

Post by celagon » Thu May 10, 2018 21:51

It seams ignore npc only death isnt working.
I klicked it in sso tokens settings but still grabbed an npc kill.

neffets
Greenhorn
Posts: 28
Joined: Fri May 24, 2013 12:06

Re: EDK 4.4.0.0 with ESI support

Post by neffets » Fri May 11, 2018 15:27

Also one small error showed up:

Code: Select all

http://my.site/index.php/admin_esisso/

Notice: Undefined variable: message in /killboardfolder/common/smarty/sysplugins/smarty_internal_data.php on line 291

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK 4.4.0.0 with ESI support

Post by Salvoxia » Fri May 11, 2018 15:53

@celagon:

Hmm, I couldn't reproduce that.
Keep in mind that ESI fetch and zKBFetch have separate settings for ignoring NPC only kills.
If you already respected that, and it still didn't work correctly, could you please link such a kill?
Maybe the "NPC detection" has problems under certain circumstances..


@neffets:
Thanks for reporting. That's a minor "uncleanliness" in the template engine's code, and only visible due to wrong error reporting settings.
A hotfix for this can be found here.

Considering your corp's huge kill history, I'm really interested in whether ESIFetch worked through all right :)
And I'll take a look into reporting the last kill timestamp as well.


Best Regards,
Salvoxia

neffets
Greenhorn
Posts: 28
Joined: Fri May 24, 2013 12:06

Re: EDK 4.4.0.0 with ESI support

Post by neffets » Fri May 11, 2018 16:23

awesome, i can't say thank you enough for the effort you put in this!

FYI:
Currently killboard is arround killid 10bil, so nearly 15% is done (max-killid as of today is near the 70bil)
I'm currently processing ~800kills/minute, while ~25 kills per 1000 fetched are getting posted.
so far its running really smooth, sometimes i get a "no result in last esi runs, skipping" message, but that only lasts a few minutes. And two times I had to change CHMOD on some cache-folders.

neffets
Greenhorn
Posts: 28
Joined: Fri May 24, 2013 12:06

Re: EDK 4.4.0.0 with ESI support

Post by neffets » Fri May 11, 2018 20:09

Aand i run into a not parsable kill:

https://esi.tech.ccp.is/latest/killmail ... fa8cd6c65/
2018/05/11 18:09:19 - Error processing involved party. Kill-ID: 16522946, KillID = 16522946

Post Reply

Return to “General Killboard Chat”

Who is online

Users browsing this forum: No registered users and 8 guests