Page 35 of 36

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Sun Jan 21, 2018 22:40
by Rayven Kaundur
Again, sorry for posting to something that appears to be a deads topic, but I just installed the mod and am getting this error:

Code: Select all

[Sun Jan 21 20:38:00.184588 2018] [:error] [pid 29777] [client 75.109.16.63:51256] PHP Fatal error:  Uncaught Error: Cannot access protected property pHome::$view in /var/www/kb/mods/rank_mod/init.php:35\nStack trace:\n#0 /var/www/kb/common/includes/class.pageassembly.php(80): RankModHome::topLists(Object(pHome))\n#1 /var/www/kb/common/includes/class.pageassembly.php(37): pageAssembly->call('RankModHome::to...')\n#2 /var/www/kb/common/home.php(866): pageAssembly->assemble()\n#3 /var/www/kb/common/index.php(323): include('/var/www/kb/com...')\n#4 /var/www/kb/index.php(25): include('/var/www/kb/com...')\n#5 {main}\n  thrown in /var/www/kb/mods/rank_mod/init.php on line 35, referer: https://kb.thedoubled.org/?a=admin_mods
Server specs:

Server: Linux thedoubled 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Apache: Apache/2.4.18 (Ubuntu)
MySQL: Ver 14.14 Distrib 5.7.20, for Linux (x86_64) using EditLine wrapper
PHP: PHP 7.0.22-0ubuntu0.16.04.1 (cli) ( NTS )

Can anyone assist in this?

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Fri Jan 26, 2018 15:41
by Salvoxia
Hi,

I've been without a working computer for some time now, so I couldn't test it. This particular error should be fixed by replacing the following code in rank_mod/init.php in lines 35 and 44

Code: Select all

if( $home->view != 'losses' )
with

Code: Select all

if( $home->getView() != 'losses' )
Of course it's possible there are other problems as well, you'll know as soon as you have applied the changes above.

Best Regards,
Salvoxia

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Tue Mar 13, 2018 16:04
by Rayven Kaundur
Fresh install of EveDev Killboard, latest version. The most recent version of Rank_Mod. Wehn in the settings admin section, clicking on check awards, generates a blank page and the below error in the apache log:


[Tue Mar 13 13:50:36.072228 2018] [:error] [pid 13517] [client 75.109.16.63:59998] PHP Fatal error: Uncaught Error: Call to undefined method RankModTopISKKillsList::TopList() in /var/www/killboard/mods/rank_mod/init.ph$

The purge medals button and the rest of the settings seem to work with no issues.

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Tue Mar 13, 2018 19:48
by Salvoxia
Hi,

that's the difference between EDK3 and EDK4 showing.
Please try replacing your mods/rank_mod/init.php with the attached one.

Best Regards,
Salvoxia

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Fri Mar 16, 2018 16:42
by Rayven Kaundur
I put your init.php file in and I am able to do all of the admin pages, however, once I enable the mod and go to the home page, I get a blank page and this in the apache error log

[Fri Mar 16 14:33:21.163605 2018] [:error] [pid 18352] [client 75.109.16.63:60655] PHP Fatal error: Uncaught Error: Cannot access protected property pHome::$week in /var/www/killboard/mods/rank_mod/init.php:203
Stack trace:
#0 /var/www/killboard/mods/rank_mod/init.php(37): RankModAwards::getMonthlyTopKiller(Object(pHome))
#1 /var/www/killboard/common/includes/class.pageassembly.php(80): RankModHome::topLists(Object(pHome))
#2 /var/www/killboard/common/includes/class.pageassembly.php(37): pageAssembly->call('RankModHome::to...')
#3 /var/www/killboard/common/home.php(866): pageAssembly->assemble()
#4 /var/www/killboard/common/index.php(323): include('/var/www/killbo...')
#5 /var/www/killboard/index.php(25): include('/var/www/killbo...')
#6 {main}
thrown in /var/www/killboard/mods/rank_mod/init.php on line 203, referer: https://kb.thedoubled.org/index.php/admin_mods/

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Sat Mar 17, 2018 11:45
by Salvoxia
Hi,

I fixed some more things, this time with the opportunity to test it. Did not find any more errors, but please report back if you do.
I took the liberty to advance the mod version to 1.02 for this.

Dowload: Rank Mod 1.02

Best Regards,
Salvoxia

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Sun Mar 25, 2018 02:44
by Rayven Kaundur
Can't download the file, I get a zero byte file when I attempt.

Edit: Actually, I was getting a message that this type of file is not normally downloaded (This is in Firefox AND Chrome) Firefox leaves it as a zero (0) byte file but Chrome will allow me to keep the file so I got your most recent patch and I'll test that. Just curious as to why Firefox and Chrome bitch about the file.

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Sun Mar 25, 2018 14:10
by Rayven Kaundur
Newest version installed. All other admin pages saved and then running DB Maintenance, I get the following error:

Code: Select all

[Sun Mar 25 12:06:16.236182 2018] [:error] [pid 4366] [client 75.109.16.63:52412] PHP Fatal error:  Uncaught Error: Call to undefined method RankModAwards::getWeek() in /var/www/killboard/mods/rank_mod/init.php:203
Stack trace:
#0 /var/www/killboard/mods/rank_mod/settings.php(444): RankModAwards::getMonthlyTopKiller(Object(RankModAwards))
#1 /var/www/killboard/mods/rank_mod/settings.php(144): RankModAdmin->viewDBMaintenance(Object(RankModAdmin))
#2 /var/www/killboard/common/includes/class.pageassembly.php(70): RankModAdmin->checkViews(Object(RankModAdmin))
#3 /var/www/killboard/common/includes/class.pageassembly.php(37): pageAssembly->call('this->checkView...')
#4 /var/www/killboard/mods/rank_mod/settings.php(983): pageAssembly->assemble()
#5 /var/www/killboard/common/index.php(315): include('/var/www/killbo...')
#6 /var/www/killboard/index.php(25): include('/var/www/killbo...')
#7 {main}\n  thrown in /var/www/killboard/mods/rank_mod/init.php on line 203, referer: https://kb.thedoubled.org/?a=settings_rank_mod&view=rankmod_db_maintenance
FYI, I no longer get a blank page when the module is enabled and I go to the homepage, however it breaks the user display page and I get this error in the logs:

Code: Select all

[Sun Mar 25 12:15:04.192461 2018] [:error] [pid 4585] [client 75.109.16.63:52786] PHP 8192:  Non-static method RankModMedalsAssigned::buildPilotMedalData() should not be called statically in /var/www/killboard/mods/rank_mod/init.php on line 1952, referer: https://kb.thedoubled.org/?a=home

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Mon Mar 26, 2018 13:15
by Salvoxia
Hi,

regarding the download problems, that seems to be related to URL forwarding.. haven't seen this before. I switched the top level domain, should work better now.
As for the errors: Ok, that's now PHP7 (except for the first). I did another test run with PHP7.1 and added some more fixes.
Thanks for bearing with me, we'll get there :)

Dowload: Rank Mod 1.03

Best Regards,
Salvoxia

Re: [EDK3] rank_mod 1.01 - custom pilot ranks, medals and stats

Posted: Mon Mar 26, 2018 14:06
by Rayven Kaundur
Download worked perfectly this time, I'll get it installed asap and let you know.

Thank you so much for working this issue.