[EDK4] Most Expensive Kills (and pod kills) 1.4

Discuss/Upload mods to the EVE-Dev Killboard.
noise331
Noob
Posts: 3
Joined: Wed Jul 04, 2012 18:08

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by noise331 »

I saw a post about changing the color of kill/loss amounts to green and red in the new update. I have installed the mod but it only seems to show in green eve for losses. Is there a setting anywhere iv missed?

User avatar
Dism0
Active Author
Posts: 158
Joined: Fri Jul 06, 2012 01:42

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Dism0 »

anyone know how to get this mod to update more frequently? it takes a while for a new kill to show up in the top 5.

User avatar
Salvoxia
Developer
Posts: 1598
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Salvoxia »

Hi,

I have not yet observed this behavior, however I haven't really paid any attention to how long it takes for an expensive kill to show up in the list.
I took a quick look at the code, it uses the KillList class, just as the kill list tables do (the front page).
So it doesn't really make sense for a discrepancy to exist.
However, query caching is always a suspect for causing such behavior, do you have any enabled (file based or memcached query caching)?

User avatar
Dism0
Active Author
Posts: 158
Joined: Fri Jul 06, 2012 01:42

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Dism0 »

indeed i do have the caching enabled. i've turned it off now so hopefully it'll update promptly.

underwoodr
Apprentice
Posts: 62
Joined: Sat Jan 31, 2009 03:23

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by underwoodr »

KB seems to think its 2015 already?
http://puu.sh/dNwWE/8675930f7c.jpg

User avatar
Salvoxia
Developer
Posts: 1598
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Salvoxia »

Yeah, that seems to be a bug in PHP's gmdate() method: https://bugs.php.net/bug.php?id=33957
Will look around if there's a feasable workaround for older PHP versions.

Redhouse
Apprentice
Posts: 46
Joined: Sun Mar 18, 2012 17:12

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Redhouse »

AHH! I was wondering what was causing this, and figured it was some kind of year end bug, but this goes deeper. In the meantime I switched display type to 'days period' of 30 which will be fine until new year rolls around.

User avatar
Salvoxia
Developer
Posts: 1598
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by Salvoxia »

Did a little more digging: In fact, according to ISO 8601 (which applies to he gmdate() method with the argument 'W' passed, which is used by the killboard), this week is the first week of 2015. See http://en.wikipedia.org/wiki/ISO_8601#Week_dates
So this is not a bug, but working as intended :)

omni
Greenhorn
Posts: 15
Joined: Sun Mar 10, 2013 23:07

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by omni »

It's not a fix, but it does at least show the correct month.

Open up class.mostexpensive.php
At the end of the file replace:

Code: Select all

			else
			{
				$y = (int) kbdate("o");
			}
			if ($m < 10) $m = "0" . $m;
			if ($w < 10) $w = "0" . $w;
			self::$year = $y;
			self::$month = $m;
			self::$week = $w;
		}
	}
With

Code: Select all

			else
			{
				$y = (int) kbdate("o");
			}
			if ($w == 1 && $m == 12) $m = 1;
			if ($m < 10) $m = "0" . $m;
			if ($w < 10) $w = "0" . $w;
			self::$year = $y;
			self::$month = $m;
			self::$week = $w;
		}
	}

User avatar
prometh
Advanced
Posts: 170
Joined: Thu Aug 09, 2012 19:25
Contact:

Re: [EDK4] Most Expensive Kills (and pod kills) 1.4

Post by prometh »

I added a couple of fixes for the usage of simple urls:

https://bitbucket.org/snitchashor/moste ... master.zip

Cheers,
Snitch

Post Reply