[EDK4] eve-kill DISQUS comments

Discuss/Upload mods to the EVE-Dev Killboard.
User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] eve-kill DISQUS comments

Post by Salvoxia » Wed Aug 31, 2016 21:28

Hi,

could you please elaborate on that function? In the image in this post http://evekb.org/forum/viewtopic.php?f= ... =10#p42727 I can see that the old mod somehow displayed the number of comments at eve-kill in the kill list table.
Did it just display the number for all kills or did you have to click on a link to trigger loading the number of comments? I looked at the old code, but it was not very revealing to me about that point.

Best Regards,
Salvoxia

Explorus
Greenhorn
Posts: 22
Joined: Thu Oct 18, 2012 08:20

Re: [EDK4] eve-kill DISQUS comments

Post by Explorus » Wed Aug 31, 2016 22:10


User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] eve-kill DISQUS comments

Post by Salvoxia » Mon Sep 05, 2016 16:19

Hi,

I did a little digging and found it should be possible. It will take a while, though.

Best Regards,
Salvoxia

Explorus
Greenhorn
Posts: 22
Joined: Thu Oct 18, 2012 08:20

Re: [EDK4] eve-kill DISQUS comments

Post by Explorus » Tue Sep 06, 2016 16:55

thx i w8 =)

User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] eve-kill DISQUS comments

Post by Salvoxia » Fri Sep 09, 2016 17:02

Hi,

here's the new version, which supports displaying the number of comments a kill has on zKillboard in kill list tables (e.h. the front page).
Some examples, so you know how it looks:
0local_8zkb.png
0 local comments, 8 at zKillboard
0local_8zkb.png (1.41 KiB) Viewed 5746 times
1local_0zkb.png
1 local comment, none at zKillboard
1local_0zkb.png (1.32 KiB) Viewed 5746 times
1local_10zkb.png
1 local comment, 10 at zKillboard
1local_10zkb.png (1.29 KiB) Viewed 5746 times
If there is a number in brackets, that's the number of comments at zKB.
Let me know if everything works :)

Best Regards,
Salvoxia
Attachments
zkb_disqus_11.zip
zKB Disqus Mod v1.1
(5.51 KiB) Downloaded 126 times

User avatar
prometh
Advanced
Posts: 170
Joined: Thu Aug 09, 2012 19:25
Contact:

Re: [EDK4] eve-kill DISQUS comments

Post by prometh » Wed Sep 14, 2016 09:25

Most of it works nicely however the combination of this and the eve+ theme can hardly be read. Diswus directly detects the color for links but does not switch to white text for actual comments which it should based on the css properties of the page.

User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] eve-kill DISQUS comments

Post by Salvoxia » Wed Sep 14, 2016 11:17

I'll check if there's some way to override the CSS, so that a custom comment text color can be configured in the mod's settings.

User avatar
prometh
Advanced
Posts: 170
Joined: Thu Aug 09, 2012 19:25
Contact:

Re: [EDK4] eve-kill DISQUS comments

Post by prometh » Wed Sep 14, 2016 14:15

I tried this, but the disqus thread wozld never change the font color:

https://help.disqus.com/customer/portal/articles/545277


Image

User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4] eve-kill DISQUS comments

Post by Salvoxia » Wed Sep 14, 2016 19:14

Yeah, the comments are loaded inside an IFrame that loads its own CSS, there doesn't seem to be a way to influence that.. :?

Explorus
Greenhorn
Posts: 22
Joined: Thu Oct 18, 2012 08:20

Re: [EDK4] eve-kill DISQUS comments

Post by Explorus » Wed Sep 14, 2016 21:38

Salvoxia wrote:
Fri Sep 09, 2016 17:02
Hi,

here's the new version, which supports displaying the number of comments a kill has on zKillboard in kill list tables (e.h. the front page).
Some examples, so you know how it looks:
1local_10zkb.png
1local_0zkb.png
0local_8zkb.png
If there is a number in brackets, that's the number of comments at zKB.
Let me know if everything works :)

Best Regards,
Salvoxia
Hello!
have problem, i have only local comment show, but i have 1 local comment and 1 zkb comment.
Image
Image
me need change anything in Settings - Eve-Kill DISQUS?

Link on board: http://galaxy-spiritus.com
Link on kill: http://galaxy-spiritus.com/?a=kill_detail&kll_id=33507

Post Reply

Return to “Modding”

Who is online

Users browsing this forum: No registered users and 7 guests