[Https] Image display

Please report bugs here, please be very detailed in your bug reports. If you've come up with some code to fix the bug, please post it here.
Post Reply
your favourite canadian
Noob
Posts: 7
Joined: Wed Jun 04, 2014 22:33

[Https] Image display

Post by your favourite canadian » Fri Aug 15, 2014 00:04

If you use https for your killboard, but also have "use CCP image server" selected, you still receive images via http:images.eveonline.com

This causes issues for browser trust as not all assets are being delivered via https.

Heres a thread on the eveonline forums which takes about CCP images servers, and touches on https for images.
https://forums.eveonline.com/default.as ... s&t=349200

In the meantime, can someone please identify the file I would need to modify to change the source URL for images on my killboard? I am having difficulty finding it.

your favourite canadian
Noob
Posts: 7
Joined: Wed Jun 04, 2014 22:33

Re: [Https] Image display

Post by your favourite canadian » Fri Aug 15, 2014 00:21

found this....
\common\includes\constants.php

Line 20:

Code: Select all

define('IMG_SERVER', "image.eveonline.com");
So changing that to:

Code: Select all

define('IMG_SERVER', "https://image.eveonline.com");
should act as a workaround?

User avatar
Salvoxia
Developer
Posts: 1531
Joined: Wed Feb 22, 2012 12:11

Re: [Https] Image display

Post by Salvoxia » Fri Aug 15, 2014 09:18

Hi,

nice catch.
But there's still a "http://" hardcoded in the class handling the image URL. If you change your constants.php like this, you need to remove it in common/class.imageurl.php line 62:

Code: Select all

$url = "http://".IMG_SERVER;
Should be

Code: Select all

$url = IMG_SERVER;
Will apply this to the current dev branch as well.

edit: In addition to the changes above, there are some other places in the code where the IMG_SERVER constant is used together with a hardcoded URL scheme. See this patch for proper handling: https://github.com/evekb/evedev-kb/comm ... d1bef5dd47

Regards,
Salvoxia

your favourite canadian
Noob
Posts: 7
Joined: Wed Jun 04, 2014 22:33

Re: [Https] Image display

Post by your favourite canadian » Sat Aug 16, 2014 01:24

Thanks for responding to this so quickly :)

Post Reply

Return to “Bug Reporting”

Who is online

Users browsing this forum: No registered users and 2 guests