EDK Assigning ExternalIDs to Moons

Please report bugs here, please be very detailed in your bug reports. If you've come up with some code to fix the bug, please post it here.
Post Reply
1450
Greenhorn
Posts: 10
Joined: Thu Jan 16, 2014 03:55

EDK Assigning ExternalIDs to Moons

Post by 1450 » Sun Sep 07, 2014 22:39

A moon used to be classed as a Victim/Pilot and the Tower was it's Ship,

When browsing the pilot information page, EDK seems to come up with an ExternalID and assigns it to the moon.

This causes an error with the CCP API as it attempts to resolve an invalid CharacterID.

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK Assigning ExternalIDs to Moons

Post by Salvoxia » Mon Sep 08, 2014 07:23

Thank you very much for reporting! Will definitely take a look at this! Even though i THINK this should no longer happen as Moons and Systems are now named using the scheme <corpName> - <moonName>, which cannot be resolved to a moonID/systemID (not 100% sure about the text mail parser, but I don't even like that ;) ). But will check on it.

Regards,
Salvoxia

1450
Greenhorn
Posts: 10
Joined: Thu Jan 16, 2014 03:55

Re: EDK Assigning ExternalIDs to Moons

Post by 1450 » Mon Sep 08, 2014 14:17

Hi Salvoxia,

I noticed this happening with 2010 evemails, I didn't check anything more recent as I basically pulled up the results from the top of the search list.

I'll try do some more digging...

I set the ExtID to 0 in the DB however it still assigns...

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK Assigning ExternalIDs to Moons

Post by Salvoxia » Mon Sep 08, 2014 16:07

Hi,

I have a pretty good idea of whats happening (the CharacterID API endpoint returning IDs of moons/systems if called with a moon's/system's name). Will add sanitation check for that.

Regards,
Salvoxia

1450
Greenhorn
Posts: 10
Joined: Thu Jan 16, 2014 03:55

Re: EDK Assigning ExternalIDs to Moons

Post by 1450 » Mon Sep 08, 2014 19:44

Much appreciated :)

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK Assigning ExternalIDs to Moons

Post by Salvoxia » Thu Sep 11, 2014 18:13

Hi,

quick update on this one: I have a fix ready, I'm currently testing it on my production board. All seems well so far, if nothing else pops up I'll push it to the repo this weekend.

Regards,
Salvoxia

User avatar
Salvoxia
Developer
Posts: 1528
Joined: Wed Feb 22, 2012 12:11

Re: EDK Assigning ExternalIDs to Moons

Post by Salvoxia » Sun Sep 14, 2014 11:40

Hi,

you can now find the patch here: https://github.com/evekb/evedev-kb/comm ... eafa950bf2


Regards,
Salvoxia

Post Reply

Return to “Bug Reporting”

Who is online

Users browsing this forum: No registered users and 10 guests