[Https] Image display

[your favourite canadian]

If you use https for your killboard, but also have "use CCP image server" selected, you still receive images via http:images.eveonline.com

This causes issues for browser trust as not all assets are being delivered via https.

Heres a thread on the eveonline forums which takes about CCP images servers, and touches on https for images.
https://forums.eveonline.com/default.as ... s&t=349200

In the meantime, can someone please identify the file I would need to modify to change the source URL for images on my killboard? I am having difficulty finding it.

[your favourite canadian]

found this....
\common\includes\constants.php

Line 20:

Code: Select all

define('IMG_SERVER', "image.eveonline.com");

So changing that to:

Code: Select all

define('IMG_SERVER', "https://image.eveonline.com");

should act as a workaround?

[Salvoxia]

Hi,

nice catch.
But there's still a "http://" hardcoded in the class handling the image URL. If you change your constants.php like this, you need to remove it in common/class.imageurl.php line 62:

Code: Select all

$url = "http://".IMG_SERVER;

Should be

Code: Select all

$url = IMG_SERVER;

Will apply this to the current dev branch as well.

edit: In addition to the changes above, there are some other places in the code where the IMG_SERVER constant is used together with a hardcoded URL scheme. See this patch for proper handling: https://github.com/evekb/evedev-kb/comm ... d1bef5dd47

Regards,
Salvoxia

[your favourite canadian]

Thanks for responding to this so quickly