[EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Discuss/Upload mods to the EVE-Dev Killboard.
Bas
Apprentice
Posts: 65
Joined: Sun Apr 20, 2014 12:11
Location: Russia, Moscow
Contact:

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Bas »

Hello!

Image

I using the default skin w/o any modifications (fresh install).
I can fix this manually, but may be you want to fix this in default installation too ;]

User avatar
prometh
Advanced
Posts: 170
Joined: Thu Aug 09, 2012 19:25
Contact:

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by prometh »

Bas wrote:
Mon Nov 07, 2016 09:46
Hello!

Image

I using the default skin w/o any modifications (fresh install).
I can fix this manually, but may be you want to fix this in default installation too ;]
It looks like you are using my modified version (3d ships). Can you try to replace the stylesheet INSIDE THE MOD FOLDER with the one included in this zip: download/file.php?id=1367

Bas
Apprentice
Posts: 65
Joined: Sun Apr 20, 2014 12:11
Location: Russia, Moscow
Contact:

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Bas »

prometh wrote:
Mon Nov 07, 2016 13:47
It looks like you are using my modified version (3d ships).
Confirm.
prometh wrote:
Mon Nov 07, 2016 13:47
Can you try to replace the stylesheet INSIDE THE MOD FOLDER with the one included in this zip: download/file.php?id=1367
Awesome! Tnx! Looks fine now.

trix12345
Greenhorn
Posts: 16
Joined: Wed Oct 19, 2011 05:17

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by trix12345 »

https://crest-tq.eveonline.com/killmail ... 93ce7f3e5/

division by zero in 668, 670 strings in init.php affect by $tau = $recharge/$k; where $recharge = (Fitting::$shipStats->getCapRecharge()/1000); $recharge = 0 in this killmail, but others with the simillar ship dont provide any problems

User avatar
Salvoxia
Developer
Posts: 1598
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Salvoxia »

Thank you for reporting, I will have to take a closer look at that!

User avatar
edp
Someday Author
Posts: 95
Joined: Fri Sep 25, 2009 19:10

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by edp »

With the latest php (php7), there are now deprecated error/info notices:

PHP 8192: Methods with the same name as their class will not be constructors in a future version of PHP; fitting has a deprecated constructor in /var/www/mods/ship_display_tool/fitting.class.php on line 9

PHP 8192: Methods with the same name as their class will not be constructors in a future version of PHP; shipstats has a deprecated constructor in /var/www/mods/ship_display_tool/class.shipstats.php on line 2

PHP 8192: Methods with the same name as their class will not be constructors in a future version of PHP; shipEffect has a deprecated constructor in /var/www/mods/ship_display_tool/class.shipEffects.php on line 2

User avatar
edp
Someday Author
Posts: 95
Joined: Fri Sep 25, 2009 19:10

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by edp »

The fixes are easy.

In class.shipEffects.php change line 13 to be:

Code: Select all

	function __construct($kll_id) {
In class.shipstats.php change line 110 to be:

Code: Select all

	function __construct(){
and in fitting.class.php change line 13 to be:

Code: Select all

	function __construct($kll_id) {
Finally, to fix a number of non-statically called methods that are being called statically, use the revised init.php file that is attached.
Attachments
init.zip
(29.47 KiB) Downloaded 296 times

User avatar
Rayven Kaundur
Greenhorn
Posts: 21
Joined: Thu Jul 27, 2017 22:27

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Rayven Kaundur »

Can someone help with this error? Version 3.7.1 of the tool and latest init.php installed. After actvation and then displaying a kill page, I get a blank page and the following error in my Apache logs:

Code: Select all

PHP Fatal error:  Uncaught Error: Class 'shipstats' not found in /var/www/kb/mods/ship_display/init.php:125
Stack trace:
#0 /var/www/kb/common/includes/class.pageassembly.php(80): fittingTools::displayFitting(Object(pKillDetail))
#1 /var/www/kb/common/includes/class.pageassembly.php(44): pageAssembly->call('fittingTools::d...')
#2 /var/www/kb/common/kill_detail.php(1812): pageAssembly->assemble()
#3 /var/www/kb/common/index.php(323): include('/var/www/kb/com...')
#4 /var/www/kb/index.php(25): include('/var/www/kb/com...')
#5 {main}\n  thrown in /var/www/kb/mods/ship_display/init.php on line 125, referer: https://kb.iconalliance.org/
Ubuntu 16.04, Apache2, PHP 7

User avatar
Rayven Kaundur
Greenhorn
Posts: 21
Joined: Thu Jul 27, 2017 22:27

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Rayven Kaundur »

Concerning the issue above, can anyone assist and point me in the right direction?

User avatar
Salvoxia
Developer
Posts: 1598
Joined: Wed Feb 22, 2012 12:11

Re: [EDK4.2.16+]: Ship Display Tool v3.7.1 - Updated: 2016/05/05

Post by Salvoxia »

Hi,

I took a quick look at my sources, but did not find anything.
Could you please link the site you downloaded the mod version from, that you are currently using? There are quite some different versions and branches out there, so I might be looking at something completely different.

Best Regards,
Salvoxia

Post Reply