[EDK4] Most Expensive Kills (and pod kills) 1.4

[leecraven]

I waited for this mod and was hoping it would come, I used NA Most expensive before and wanted the same formatting again and to include pods, great work on this, thankyou.

Would it be possible to have the background of names colored red/green (kills/losses) ? Not sure how simple/hard that would be but I know it would look great with it

[Khi3l]

Will try to do this in next release after January 1st

[Mavrik347]

Bug:

http://www.sev3rance.com/kb/index.php?a=home

Fon Revedhort - 829.89 Million ISK
Actual loss: 3,814,607,262 ISK

Also shows losses even when only kills is selected.

[Khi3l]

1.4 relesed, see first post.

[Khi3l]

Bug:

http://www.sev3rance.com/kb/index.php?a=home

Fon Revedhort - 829.89 Million ISK
Actual loss: 3,814,607,262 ISK

Also shows losses even when only kills is selected.

This is not a mod issue but an issue with the way the new EDK4 calculate ship lost value.

[Mavrik347]

But it's displayed correctly on the kill pages "Ship Details" so surly it's a mod problem? Although it would appear the fitting mod has the same issue.

[Lum]

Today (1st of January, 2012) this mod was showing most expensive kills/losses for January 2011. Seemingly this is caused by the formatting used with the php date function by which today is part of a week which is part of last year.

Changing the following in class.mostexpensive.php seemed to fix the issue:

Code: Select all

				$y = (int) kbdate("o");

..changed to..

Code: Select all

				$y = (int) kbdate("Y");

[Khi3l]

Good, will add this fix in next release.

[ashridah]

Hey, i'm trying to set this up, and for some reason, it's treating pod losses as kills, even though i've put our corp id into the settings page. (using v1.4)

I double-checked the corp id against the api, so i know have the right one, but it seems that the logic at class.mostexpensive.php:176 is broken. We have a corp-only board, we're not members of an alliance, and it seems to fall through every time to the catch-all case at line 193. (alliance and pilot ids are 0)

I'll poke at it a bit more and see if i can identify why it's not matching line:

elseif (config::get("mostexp_corpid") && $pod->getVictimCorpID() == config::get("mostexp_corpid"))

I only just upgraded to EDK 4.0.3 from 3.2.x, so it's possible that some old data for this loss exists and perhaps that field is coming up empty or something, i'll see.

[highonpop]

I just installed this on my KB

The time limit being tracked in the module is not the actually #of days displayed. I am doing 30 days, and the module says "January 2012" as the time limit. On Feb 1, if this changes, the displayed kills will be inaccurate for the stated time.

If it is Feb 1 and the module says "Most Expensive kills for February 2012", and its tracking the last 30 days, will still show January kills as "February" kills

This should say the actual number of days being tracked and not the current month.