idun wrote:This is interesting but I'd much rather have it display Evekill comments with the disqus login in addition to local comments instead of replacing regular password-based commenting. I'm mostly done modifying this to accomplish:
- Enable both local and EVE-Kill comments (also list both counts on the kill list)
- Remove the evekill cronfeed requirement
- Can comment on any kill no matter what the posting source (evekill kill ids are queried on the fly)
Done.
Essentially what this does is lookup evekill's internal kill id when the user visits the kill detail page or when fetching a mail that has it's externalID set. It will be unsuccessful if evekill doesn't have the kill or it is not API verified (we need the external CCP ID from the API verification process to perform the lookup). In that case it will simply display an error message and subsequent page loads will reattempt.
- killdetail.png (13.61 KiB) Viewed 17762 times
There's one potential performance problem: If evekill goes down, our kill detail page will block for the timeout period (currently 5 seconds). So will whatever page that's fetching the mail with it's externalID set (cron_feed.php, admin_idfeedsyndication.php, etc). Some asynchronous callback work could be done there. Note that the server actually has to be down for this to happen. If their webserver is still running, but just not returning useful data, there will be no delay on our part.
- killlist.png (7.94 KiB) Viewed 17762 times
As you can see I'm running an older kill list layout. The attached source code doesn't actually render like the above picture, but I just wanted to illustrate that both comment counts are displayed. The attached code uses the little envelope icons. The dash means comments haven't been loaded yet (in the attached source it's the link 'Load Comments' instead).
More details can be found on the settings page once the mod is installed.
One thing I don't like about this is there's no easy way that I can think of to display a count of 0 for the evekill comments! It either shows a non-zero comment count, nothing (meaning there are no evekill comments), or that comments haven't been loaded yet.
And now for something completely different:
I looked into changing the shortname like we had both thought of for vovaatom, and it's not so simple. If you're not going to use evekill as the disqus forum, then you probably don't care about evekill's internal kill id. You probably would rather just use your internal kill id as the disqus article identifier, which means the extra table that this mod creates is useless, as is the function which looks up the evekill internal id using the CCP kill ID.
I was hoping to use EPIC to lookup the kill id without having to parse a bunch of xml that we don't need, but there's a problem with that method:
https://forums.eveonline.com/default.as ... ost1761553
)