[MOD] Stats and SSO mod

[Bas]

Code: Select all

PHP Warning:  session_start(): Cannot send session cookie - headers already sent by (output started at /.../kb/cron/cron.base.php:72) in /.../kb/common/includes/class.session.php on line 47
PHP Warning:  session_start(): Cannot send session cache limiter - headers already sent (output started at /.../kb/cron/cron.base.php:72) in /.../kb/common/includes/class.session.php on line 47
PHP Warning:  session_regenerate_id(): Cannot regenerate session id - headers already sent in /.../kb/common/includes/class.session.php on line 48

If i disable the mod, all is ok.

[Salvoxia]

Hi,

there's a fix for these warnings: https://github.com/evekb/evedev-kb/comm ... 5b5129500b

Best Regards,
Salvoxia

[Bas]

Thank you.
I made changes.
Warnings are gone.

[Dism0]

apparently godaddy hosting only provides access to php 5.4 and they want you to use a more expensive hosting to use php 5.5.

[prometh]

apparently godaddy hosting only provides access to php 5.4 and they want you to use a more expensive hosting to use php 5.5.

Sorry about that. Sadly not only the code I wrote but also the libraries I use require 5.5+, I'm afraid theres not much I can do about it. Also given the last 5.4 release was in 2014 godaddy seems to be a little behind there...

[Dism0]

this mod may force me to upgrade to deluxe to get the option of 5.5+

[prometh]

In that case I would rather look for a different provider. I have now idea about pricing or benefits of godaddy but capitalizing on peoples software version requirements sounds wrong. Given they should have an interest to upgrade as e.g. php 7 uses slightly less ressources compared to 5.x...

[Dism0]

moved to a new provider.. installed and working. thanks!

[Edd Reynolds]

The variable used to set the form action url for submitting a comment conflicts with one used in edk core for updating the value of items in a kill-mail. It causes the site to try (and fail) to submit a comment when updating values. Can be fixed by renaming the variable in two places
init.php line 37

Code: Select all

$smarty->assign('ssoCmntFormURL', edkURI::page('sso_comment'));

and sso_comments.tlp line 32

Code: Select all

<form id="postform" method="post" action="{$ssoCmntFormURL}">

[Dism0]

broken.

Code: Select all

Fatal error: Uncaught League\OAuth2\Client\Provider\Exception\IdentityProviderException: CREST is no longer third party accessible. Please use ESI. in /homepages/30/d678292045/htdocs/kb/mods/statsmod/vendor/evelabs/oauth2-eveonline/src/Provider/EveOnline.php:94 Stack trace: #0 /homepages/30/d678292045/htdocs/kb/mods/statsmod/vendor/league/oauth2-client/src/Provider/AbstractProvider.php(644): Evelabs\OAuth2\Client\Provider\EveOnline->checkResponse(Object(GuzzleHttp\Psr7\Response), Array) #1 /homepages/30/d678292045/htdocs/kb/mods/statsmod/sso_login.php(132): League\OAuth2\Client\Provider\AbstractProvider->getResponse(Object(GuzzleHttp\Psr7\Request)) #2 /homepages/30/d678292045/htdocs/kb/common/index.php(319): include('/homepages/30/d...') #3 /homepages/30/d678292045/htdocs/kb/index.php(25): include('/homepages/30/d...') #4 {main} thrown in /homepages/30/d678292045/htdocs/kb/mods/statsmod/vendor/evelabs/oauth2-eveonline/src/Provider/EveOnline.php on line 94