EDK 4.4.3.0 (July 2019 1.0)

[Salvoxia]

\o guys,

after a loooong time on the last version, there's finally an update!

This update primarily updates the static data export to the latest version (June 2019), as well as updates the ESI library. The latter will take care of deprecation warnings in the ESI logs.

Of course all the hotfixes for the last version are included. This changes the way zKBFetch works a little bit. If you already applied the hotfixes, you already know what's going an there, but here's a quick explanation anyway:
Changes in the zKB API require API calls to include a start date as well as an end date. Before, EDK only used a start date and fetched a number of kills starting from that date. Due to the requirement to specify an end date as well, zKBFetch now focuses on fetching kills for a single day per cycle. So the most time you can cover with a single fetch cycle is one day (even if there are no kills for that day). That's just to keep in mind if you want to fetch the whole kill history for an entity. You can use suitable short cronjob intervals for fetching though (but no shorter than your PHP maximum execution time).

A thanks goes to Gadicuz for providing a number of bugfixes as well.



Download:
Full Install Package 4.4.3.0: Download (MD5: C54E3597A674247F747CDA55B66D15D1)
Attention: Before performing a new installation, please check the first known issue at the bottom of this post!
Update 4.4.2.0 - 4.4.3.0: Download (MD5: 830C53CCA414C4062A9C3F4863E6CBBB)


Database only:
Download the standalone database update for of EDK4.2+ here: Download (MD5: BD6C7D9AF3274A39128C91B446A5C4CC)



Release Notes:
List of new features

• Updated EDK to 4.4.3.0 and CCPDB to July 2019 1.0.20190625
• Updated ESI client with _latest on 2019-07-24

Enhancements:

• Code cleanup for compatibility with PHP 7.2
• Updated NPC corporation detection
• ESI Client: Force cURL to use IPv4 address resolution
• Sort by priority 'filter' and 'addBehind' page assembly items

Bugfixes:

• Fix: Fixed possible SQL error when fetching unknown items from ESI
• Fix: ZKBFetch must use startTimestamp AND endTimestamp
• Fix: Post kills within the classification time frame
• ZKBFetch: Fix for fetching kill history from zKillboard
• ESI: Standardized HTTP response headers with lower case
• Fix for kills containing attackers with alliance ID, but without weapon type or character ID
• Fixed cURL handle used after closed when there is an error.
• Fixed missing use in pilot_detail page.

Installation Instructions:

New Installations

• Upload the whole package to a webhost
• Point your webbrowser to /install inside the EDK directory
• Follow the instructions
• Delete the install folder after installation
• If no pilot images are displayed check that the server has write permission to the cache folder.

Manual upgrade

• Backup the existing database and files
• Remove or rename all files in the killboard folder other than [kbfolder]/kbconfig.php
• Upload the new package to the killboard folder
• Remove install folder
• Move your mods back from the backup to the mods folder.

Update from 4.4.3.0:

Auto Updater

• Backup the existing database and files
• Enter the admin control panel
• Select the option "Upgrade" from the menu on the right
• If the code update to Version 4.4.2.0 doesn't show up in the list, select the link at the bottom saying "retrieve update description file now"
• Click "Download"
• Click "Apply"
• Database update process starts, follow instructions
• DONE \o/

Manual upgrade

• Download the Update 4.4.3.0 - 4.4.2.0 (see above)
• Backup the existing database and files
• Upload the contents of the update package to your webhost
• DONE

Known issues:
SQL error / package import error on fresh installations
When importing the SQL packages (installation step 4) into the database, you might see failed queries starting at around package 15.
A hotfix is available for this. Please replace your install/install_step4.php with this one.


Best Regards,
Salvoxia

[Redhouse]

Hi, I'm having some trouble with this.
The update installs without error to 4.4.3.0 in my case but after doing so I'm not able to post a killmail. Posting the mail returns an empty page.

I searched around google for some edk boards and tried to post a mail to them and they all gave the same result (they were mostly running 4.4.2.0 though). I notice a couple spit out error codes rather than a blank page:

Code: Select all

Error connecting to the API (https://esi.evetech.net/v2/universe/names/?datasource=tranquility)'

On the board in question, I have a feed syndication setup that now returns:

Code: Select all

[404] Error connecting to the API (https://esi.evetech.net/v3/universe/names/?datasource=tranquility)

Any idea what's going on? After some searching I'm not even sure what logfile would collect this error (/cache/error.log doesn't appear to be useful).

[Salvoxia]

Hi,

that's due to CCP messing up the universe/names endpoint for translating entity IDs to names. Refer to https://github.com/esi/esi-issues/issues/1134 .
It seems this will only be fixed after the weekend on CCP's end.

A year ago or so there was a time when CCP disabled that endpoint due to abuse (ID scraping). During that time, EDK used entity specific endpoints for ID translation.
That code should still be available in Git and should still be working. I'll dig around and report back with some modified files.

Best Regards,
Salvoxia

[Redhouse]

Awsome, thanks.

[Salvoxia]

Hi,

I checked out the old code. Unfortunately, the functionality it was using was removed from ESI last year.
So I'm afraid there's not feasable quick fix for this situation, and we'll have to wait for CCP to fix this problem on Monday.
Sorry for that.

Best Regards,
Salvoxia

[Redhouse]

Not a huge problem. Thanks for finding the root cause and looking into a potential fix.

[MrJayIsAGoon]

Thanks for running this one down! Hopefully CCP can un-!@#$% their %^&*( soon.

[Salvoxia]

This issue should be fixed since downtime today.

[Redhouse]

Everything appears to be working, it was just a coincidence for me that I decided to upgrade right as that bug was present.

[Redhouse]

I noticed an issue with the ccp image server where requests like:
https://image.eveonline.com/InventoryType/622_32.png
would result in 'bad path' response, and no image.

Changing to
https://image.eveonline.com/Type/622_32.png
gives the expected response

I changed class.imageurl.php line 86 to

Code: Select all

                        $url .= "/Type/{$id}_{$size}.png";

I couldn't find this as part of an announced change, so maybe it's a mistake on their part. Another thing I note is that the image url format used on the edk board doesn't appear to fit with the listed formats on https://imageserver.eveonline.com/ either. For some reason this didn't affect the /characters/ or /render/ 'types'

This might affect a few more types and I'm not sure if this is a permanent change that needs a fix or not. Found an article on it: https://developers.eveonline.com/blog/a ... -service-1 but it seems a few routes are still broken like alliances

a dirrty fix inside class.imageurl.php from line ~62 that I applied based on this:

Code: Select all

			$url = "https://images.evetech.net";
        }

        if ($ccp || config::get('cfg_pathinfo')) {
            switch ($type) {
                case 'Character':
                case 'Pilot':
                    $url .= "/characters/{$id}/portrait?size={$size}";
                    break;
                case 'Corporation':
                case 'Alliance':
                    // Check for NPC alliances recorded as corps.
                    if ($id > 500000 && $id < 500021) {
                        $url .= "/alliances/{$id}/logo?size={$size}";
                    } else {
						if ($type== 'Alliance') 
							{$url .= "/alliances/{$id}/logo?size={$size}";}
						else
							{$url .= "/corporations/{$id}/logo?size={$size}";}						
                    }
                    break;
                case 'Type':
                case 'InventoryType':
                case 'Ship':
                    if ($size > 64 && $type == 'Ship')
                        $url .= "/types/{$id}/render?size={$size}";
                    else
                        $url .= "/types/{$id}/icon";
                    break;
                case 'Render':
                    $url .= "/types/{$id}/render?size={$size}";
                    break;
                default:
                    $url .= "/types/{$id}/render?size={$size}";
                    break;