Page 2 of 2

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Tue Feb 28, 2017 21:24
by Explorus
Same problem!
"Invalid format for kill, skipping"

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 00:21
by Salvoxia
Hi,

apparently they did change something, thanks for reporting!

I'll just do a quick write-up for a workaround, right now that's all my time permits (I'll push a hotfix tomorrow):
open common/includes/class.zkbfetch.php and find the following block of code (shold be around line 329):

Code: Select all

// force API verified mails only
if(strpos($this->fetchUrl, 'api-only') === FALSE)
{
	$this->fetchUrl .= 'api-only/';
}
Remove this block completely.

This should help (not tested myself, though!).

Best Regards,
Salvoxia

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 09:02
by Explorus
Thanks, working fine for me now :)

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 10:45
by delakut
I deleted the "force API verified mails only" block and I started to download from the 2017-02-01. I still got the error messages below. If I skip the last invalid kill timestamp for one hour it runs to the next "Invalid format for kill".
ZKBApi: https://zkillboard.com/api/corporationID/155453528/
0 kills were posted and 0 were skipped (1 kills fetched). Timestamp of last kill: 2017-02-19 11:50:36
Invalid format for kill, skipping
ZKBApi: https://zkillboard.com/api/corporationID/155453528/
0 kills were posted and 0 were skipped (1 kills fetched). Timestamp of last kill: 2017-02-26 22:34:28
Invalid format for kill, skipping

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 12:07
by Salvoxia
Did it work at least once after you made the change, or didn't the change affect the result at all?

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 13:29
by delakut
hmm, I'm not hundred percent sure. I think I first got only the 27. after I made the change and not the 28. After that I deleded the cache and got the 28. too. I can't exactly reproduce it anymore. That was the reason why I started to fetched all kills from 01.02 because I wasn't sure when the problem started.

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 17:35
by Salvoxia
Hi,

I now tested and pushed the fix posted above: https://github.com/evekb/evedev-kb/comm ... 54ecc82b25

@delakut: I tested fetching for your corp, works fine on my test board:

Code: Select all

ZKBApi: https://zkillboard.com/api/corporationID/155453528/
0 kills were posted and 3 were skipped (3 kills fetched). Timestamp of last kill: 2017-02-28 20:43:39
Could you please double-check the changes above and if that does not reveal anything helpful, please attach your class.zkbfetch.php so I can test with it.

Best Regards,
Salvoxia

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Wed Mar 01, 2017 18:31
by delakut
It works now. I replaced my file with the original EDK4.2.29.0 and deleted the linies again. Maybe I still had another quickfix in there which caused the problem. Thank you for your help.

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Fri Mar 03, 2017 22:56
by Bas
Salvoxia wrote:
Wed Mar 01, 2017 00:21
I'll just do a quick write-up for a workaround, right now that's all my time permits (I'll push a hotfix tomorrow):
open common/includes/class.zkbfetch.php and find the following block of code (shold be around line 329):

Code: Select all

// force API verified mails only
if(strpos($this->fetchUrl, 'api-only') === FALSE)
{
	$this->fetchUrl .= 'api-only/';
}
Remove this block completely.
now works for me too, tnx!

Re: EDK 4.2.29.0 (YC-119.1 1.0)

Posted: Thu Mar 16, 2017 18:45
by Salvoxia
prometh wrote:
Mon Feb 20, 2017 11:48

hmmm its actually in the code and I'm not exactly sure why its no longer working, anyway it requires a change to your theme file to get it working again. open the killlisttable.tpl for the theme you are using and find the following line, should be around line 79 (for the default theme):
I tried to trace that change using the file's history, but it seems it has always been like this. So I guess I'll just apply that same fix.

Best Regards,
Salvoxia